content: a mis-scan comes back off, and an empty room is a result you can record - #263

Triggered by

• shelf.nu PR #2933: feat(audits): mobile scan undo endpoint, and honest zero-scan completion - View PR

Product change summary

Two halves of one principle: an audit record should be correctable while it is live, and its completion should be explicit rather than silently blocked.

The web scan page has had per-row scan removal all along. #2933 extracts that transaction into removeAuditScan() and puts a mobile endpoint in front of the same function, so web and phone share one implementation. Separately, the Complete Audit button used to be disabled whenever nothing had been scanned, on both the detail page (disabled={!hasScans}) and the scan drawer, so the most alarming result an audit can produce, an empty room, was the one result you could not put on the record. It is now offered, and the confirmation dialog states the consequence before anything commits.

Content changes

New content

• content/knowledge-base/run-your-first-audit.mdx - new Undoing a Scan section under Step 3. The article never documented the bin icon, which is a capability the web has had since audits shipped.
• content/knowledge-base/run-your-first-audit.mdx - new Completing an Audit Where Nothing Was Found section under Step 5.
• content/knowledge-base/run-your-first-audit.mdx - two FAQ entries: "I scanned the wrong thing. Can I take it back?" and "Can I complete an audit if I found nothing at all?"
• content/updates/an-audit-can-be-corrected-while-it-runs.mdx - changelog entry

Content enhancements

• content/knowledge-base/run-your-first-audit.mdx - Step 5's numbered list went straight from clicking Complete Audit to the summary email. It now covers the confirmation dialog the click actually opens: the Audit Summary counts, the optional Completion Note and its up-to-five photos, and the fact that completion cannot be undone. The Completion Note was previously mentioned only downstream, in the paragraph about what the PDF contains.

Skipped, blocked by an open PR

• content/features/audits.mdx - already being changed in content: Companion 1.4.0 is live — booking calendar, audit evidence, model and SAM ID #259. The feature page is the right home for one line on correcting a mis-scan mid-audit, since it is a real capability the page does not claim. Recorded as a follow-up for the run after content: Companion 1.4.0 is live — booking calendar, audit evidence, model and SAM ID #259 merges.

Review notes

Every behaviour statement is traced to main, not to the PR body:

• Removal is a bin icon, not a labelled control. generic-item-row.tsx renders icon="trash" with aria-label="Remove scanned item: <title>". The copy says "bin icon" rather than quoting a label that does not exist on screen.
• The expected branch is described as returning to Not scanned, not to MISSING. removeAuditScan writes status: "MISSING", but a live audit renders that state as Not scanned everywhere, which content: who can do what, one word for an unscanned audit asset, and no CSV of audit results #244 established. The reader-facing word is the correct one here.
• Counts are recomputed, not decremented. Three tx.auditAsset.count calls inside the same transaction.
• The refusal is quoted verbatim: "This audit is no longer live, so its scans cannot be changed." (service.server.ts, 400, shouldBeCaptured: false).
• The zero-scan warning is quoted verbatim from complete-audit-dialog.tsx: "No assets were scanned. Completing now marks all N expected assets as missing."
• Prior scans really are removable. The scan route's loader calls getAuditScans and restores them into the drawer list, so the claim that a mis-scan from yesterday is as removable as one from a minute ago holds.
• The Activity claim: removal writes an AuditNote of type UPDATE reading "{user} removed scanned asset {asset}.", and the article's existing Findings/Activity split puts Shelf's own trail on Activity.

The mobile half is stated as arriving in a future app release, not as live. POST /api/mobile/audits/remove-scan exists on main, but Companion 1.4.0 (iOS build 35, Android versionCode 15, commit 0c85873e4) predates this merge, and #2933's own body says the app UI lands separately. Nothing here claims a phone button that is not shipped.

Screenshots

No new images. Both new sections describe controls on the existing audits-scan.webp shot, and the zero-scan dialog cannot be captured without a live audit with nothing scanned in the shared demo workspace. Creating one would mean mutating a workspace other people use, so it is recorded as a follow-up with its precondition rather than faked.

Impact scope

• End users affected: anyone running an audit who mis-scans, and anyone auditing a location that turns out to be empty
• Prospects affected: none directly, this is help content
• Pages modified: 1
• Pages created: 1
• Pages flagged for review: 1 (blocked by content: Companion 1.4.0 is live — booking calendar, audit evidence, model and SAM ID #259)

Generated by Shelf Content Intelligence - PR-Website Sync

Summary by CodeRabbit

• Documentation
  • Added guidance for removing scans during active audits, including recounting, activity logs, and restoring previous scans.
  • Clarified restrictions for completed or cancelled audits.
  • Expanded audit completion instructions, including summaries, notes, photos, email notifications, PDF export, and audits with no scans.
  • Added FAQs and release updates covering scan removal and completing audits without findings.